Ensure that pdfDocument is defined when printing (issue 6083) #6086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the *first* part of issue 6083 (accessing `numPages`), since that issue applies to all versions of the viewer with printing support, by ensuring that `pdfDocument` is available when printing. *Note:* The remaining issue is specific to the `mozPrintCallback` polyfill, which this patch does not touch.
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/b0e3324e616bd73/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/b0e3324e616bd73/output.txt Total script time: 0.92 mins Published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the first part of issue #6083 (accessing
numPages), since that issue applies to all versions of the viewer with printing support, by ensuring thatpdfDocumentis available when printing.Note: The remaining issue is specific to the
mozPrintCallbackpolyfill, which this patch does not touch.(The patch also addresses some incorrect indentation in
PDFViewerApplication.beforePrint; compare with https://github.com/mozilla/pdf.js/pull/6086/files?w=1)